Add "open-with" action and context-popmenu to ark

Review Request #103690 - Created Jan. 13, 2012 and discarded

Information
Volker Härtel
ark
179066
Reviewers
kdeutils
rkcosta
Add an "open with" action to ark. Also add a context-menu (popup) for typical actions to ark. Change standard way to open files to preferred application.

This patch is based on https://svn.reviewboard.kde.org/r/6580/
Works for me

Issues

  • 12
  • 0
  • 0
  • 12
Description From Last Updated
Coding style: enum Foo { Bar, Baz }; Using a verb as an enum name isn't very good either. I'd ... Raphael Kubo da Costa Raphael Kubo da Costa
This isn't a slot anymore; please move it out of the slots section. It also needs a new name. Raphael Kubo da Costa Raphael Kubo da Costa
Same thing about "previewFileWith" not being a good name. Raphael Kubo da Costa Raphael Kubo da Costa
Please keep the include list alphabetically sorted. Raphael Kubo da Costa Raphael Kubo da Costa
Coding style: ,this I'd also break this call in two lines to keep it consistent with the others. Raphael Kubo da Costa Raphael Kubo da Costa
Since this will open a dialog, you shoud use "Open With..." instead of "Open With". Raphael Kubo da Costa Raphael Kubo da Costa
I disagree with this shortcut. It is mostly used to close tabs or windows and seems to have been chosen ... Raphael Kubo da Costa Raphael Kubo da Costa
"new Foo" is enough, there's no need to use parenthesis. Raphael Kubo da Costa Raphael Kubo da Costa
Isn't there space for a race condition here, in which this method is called many times, the slotPreviewExtracted() slot is ... Raphael Kubo da Costa Raphael Kubo da Costa
Ditto. Also please keep the line split as this is an unrelated style change. Raphael Kubo da Costa Raphael Kubo da Costa
Coding style: switch () instead of switch(). Raphael Kubo da Costa Raphael Kubo da Costa
Wrong indentation, a static_cast should be enough and there is a style error in " , this". QLatin1String is more ... Raphael Kubo da Costa Raphael Kubo da Costa
Christopher Yeleighton
Raphael Kubo da Costa
Volker Härtel
Ragnar Thomsen
Volker Härtel
Review request changed

Status: Discarded

Change Summary:

Thanks for implementing most of this. It's ok for me at the moment.

Loading...