Port shutdown dialog to QML

Review Request #103621 - Created Jan. 3, 2012 and submitted

Information
Lamarque Souza
kde-workspace
ksmserver/qml-shutdowndlg
216853
Reviewers
kde-baseapps, kde-runtime
Port shutdown dialog to QML. Two QML themes are included: default, which mimics the current shutdown dialog look & feel, and contour, which is used in Plasma Active.
Works in Plasma Active Two using MeeGo image and KDE SC 4.8. It does not work in 4.7.x because the default theme requires kde-runtime 4.8's declarative imports.

TODO:

. test right to left language support.

Issues

  • 7
  • 5
  • 1
  • 13
Description From Last Updated
As picky as it may seem, doesn't this file need a license? Raphael Kubo da Costa Raphael Kubo da Costa
Why is this needed? Raphael Kubo da Costa Raphael Kubo da Costa
Why not pass KDECLARATIVE_LIBRARIES directly to find_library() to get rid of this block? Raphael Kubo da Costa Raphael Kubo da Costa
I don't see these being used anywhere in the patch, does it make sense to keep deprecated declarations in a ... Raphael Kubo da Costa Raphael Kubo da Costa
Missing KDECLARATIVE_LIBRARIES? Raphael Kubo da Costa Raphael Kubo da Costa
Where is Copyright.txt? :) If you move this file to cmake/modules you can share the license header with the other ... Raphael Kubo da Costa Raphael Kubo da Costa
Can you elaborate on why KDECLARATIVE_LIBRARY is being used/set? Raphael Kubo da Costa Raphael Kubo da Costa
Lamarque Souza
Lamarque Souza
Albert Astals Cid
Christoph Feck
Lamarque Souza
Christoph Feck
Lamarque Souza
Lamarque Souza
Lamarque Souza
Lamarque Souza
Raphael Kubo da Costa
Lamarque Souza
Raphael Kubo da Costa
Alexander Neundorf
Alexander Neundorf
Commit Hook
Lamarque Souza
Review request changed

Status: Closed (submitted)

Loading...