Internal viewer: remember and restore the size last used

Review Request #103581 - Created Dec. 30, 2011 and submitted

Information
Jonathan Marten
ark
Reviewers
kdeutils
rkcosta
The internal file viewer is always created with a fixed size in ArkViewer::viewInInternalViewer(), there is a TODO comment in the code saying that the size should be saved and restored in the config file.  This patch implements that.

The sizeHint of the dialog is set to the original default size.  This is so that the viewer opens at a sensible size the first time that Ark is run, but it is ignored if there is a saved size.  (Ignore diff v1, had forgotten to include this.)
Built Ark with these changes, checked operation of internal viewer and that the size is correctly set initially and restored.

Issues

  • 2
  • 0
  • 0
  • 2
Description From Last Updated
This block of commented out lines can be removed. Raphael Kubo da Costa Raphael Kubo da Costa
Coding style: return foo; instead of return (foo); Raphael Kubo da Costa Raphael Kubo da Costa
Raphael Kubo da Costa
Commit Hook
Commit Hook
This review has been submitted with commit d99ba06dd8643c8394a157d01367b22b564c56b3 by Jonathan Marten to branch KDE/4.8.
Jonathan Marten
Review request changed

Status: Closed (submitted)

Loading...