GCI Task : Remove Two Actions From Tabs' Context Menu
Review Request #103451 - Created Dec. 18, 2011 and discarded
Removed the "Open The Last Closed Tab" and "Closed Tabs" actions and set ""New Tab"" button's context menu to the empty area context menu on TabBar. I am a GCI-Student who wrote this patch.
Review request changed
Fixed issues, it seems ok. But next time you'll have to present a different review requests for each task, i.e. this one should be split in two parts. Anyway, let's go straight on for now.
Wht if you remove the newTabButtonContextMenu(QPoint point) and modify emptyAreaContextMenu(const QPoint &) to work with the newTabButton? Like just replacing menu.exec(pos) with menu.exec(cursor().pos()) and adding a Q_UNUSED(pos).
Code seems ok now, but I tested your patch and I cannot really understand why we should apply such changes. Chromium and Firefox both show such actions in tabbar contextual menu, so I think you should spend some words to explain why you are suggesting such changes.