Turn internals into a library (actually two)

Review Request #103183 - Created Nov. 18, 2011 and submitted

Information
Dario Freddi
ktp-common-internals
Reviewers
telepathy
gberg
This patch turns common-internals into a library. Here follows a shortlog of changes of what I did for making this happen:

264472c Add CMake magic for making the library build
bb7e95b Now that everything has been put into a namespace, rename KPresence to Presence for consistency
ad52ffe Export the classes
b587540 Add KTelepathy namespace to base classes
b3ee5f6 Fix all warnings
83b2a68 Enforce the use of QLatin1*
5c8fc85 Enforce the non-use of Qt keywords

Missing:
 * Fix paths (so move all the source code in a KTelepathy/ subfolder) for fixing includes in header files when including from other applications. I didn't do that in the review since it would have screwed up the diff badly.
 * Port applications

George, I know you are reluctant towards this change, but the situation with the current submodules is getting unsustainable, and since we aim towards moving KTelepathy to Extragear for 0.3, we need to fix that. The concern about BC is not a problem, since we'll handle the SONUMBER accordingly, and the library will still be private for internal use until we decide for something different.

  

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
David Edmundson
Dario Freddi
Martin Klapetek
Dario Freddi
Francesco Nwokeka
George Kiagiadakis
Dario Freddi
George Kiagiadakis
David Edmundson
Commit Hook
Dario Freddi
Review request changed

Status: Closed (submitted)

Loading...