Added support for rfkill

Review Request #102983 - Created Oct. 28, 2011 and discarded

Information
Rüdiger Sonderfeld
libbluedevil
Reviewers
plasma, solid
rfkill is a subsystem of the Linux Kernel to disable radio transmitters (including Bluetooth). This patch adds support for rfkill to libbluedevil. An interface is added to the Manager class.

rfkill support is important because gnome uses rfkill to deactivate bluetooth. Therefore if bluetooth is currently disabled in the gnome-control-center it can not be used by kde. With this patch the proper API to reenable bluetooth is provided.

Disabling bluetooth with rfkill has the advantage that some computers switch off the bluetooth LED. Which does not happen (at least on my Thinkpad) if it's just powered off (as kde does at the moment).

rfkill can also detect if bluetooth has been deactivated by a hardware switch.

btw. please mark https://gitorious.org/libbluedevil/libbluedevil as obsolete and update http://projects.ufocoders.com/projects/libbluedevil/wiki. I used the old gitorious code base at first.
I added a test to bluedeviltest and it works for me.

Issues

  • 11
  • 0
  • 0
  • 11
Description From Last Updated
We use camel case for enumerate's names too. Lamarque Souza Lamarque Souza
isRfkillSwitchSupported() const; Lamarque Souza Lamarque Souza
Is rfkill supported in BSD? If so then this dev path may be different in that platform. Lamarque Souza Lamarque Souza
Is rfkill supported in BSD? If so then this dev path may be different in that platform. Lamarque Souza Lamarque Souza
Is rfkill supported in BSD? If so then this dev path may be different in that platform. Lamarque Souza Lamarque Souza
bool isValid() const Lamarque Souza Lamarque Souza
bool isValid() const Lamarque Souza Lamarque Souza
Use normalized signal/slots [1]: connect(d->m_rfkill.getFileSystemWatcher(), SIGNAL(fileChanged(QString)), this, SLOT(_k_rfkillChanged(QString))); [1] http://doc.qt.io/qt-4.8/signalsandslots.html Lamarque Souza Lamarque Souza
Please fix identation. I think the text should "RfkillSwitch supported! Status: " Lamarque Souza Lamarque Souza
} else { Lamarque Souza Lamarque Souza
"RfkillSwitch not supported in this platform" Lamarque Souza Lamarque Souza
Àlex Fiestas
Rüdiger Sonderfeld
Albert Astals Cid
AceLan Kao
Rüdiger Sonderfeld
Lamarque Souza
David Rosca
Rüdiger Sonderfeld
Review request changed

Status: Discarded

Loading...