Proxy overhaul Part 6: Proxy Configuration dialog rewrite
Review Request #102802 - Created Oct. 8, 2011 and submitted
|82352, 139789, 147340, 164460, 189019, 190149, 190901, 205594, 258196, 283226|
This patch completely overhauls the proxy configuration dialog so that it is much simpler to use and maintain. The major difference between it and the old configuration dialog is the merging of the configuration dialogs for the different proxy types into the main proxy dialog and the addition of a new input for specifying SOCKS proxy settings. See the attached screenshots to see how the new dialog looks.
- Configure proxy through dialog and validate the results by checking the settings saved in $KDEHOME/share/config/kioslaverc. - Reloading the proxy dialog to see the saved information is properly loaded back again.
Nice, work, as always :) Only one question: Do the port spin boxes need the "Port:" labels, as seen in the ASCII drawings from bug 147340? Or would it clutter the interface? Maybe a "Hostname" and "Port" headline for the two columns?
Review request changed
* Added "Port:" label to GUI. * Fixed bug in the code the loads proxy settings from file.