quicklaunch: Add a confirmation dialog before the delete
Review Request #102727 - Created Sept. 28, 2011 and discarded
Hello, This patch is adding a new feature to the quicklaunch plasmaoid.
kde-workspace compiles fine.
Hey! Even though I'm not anymore the maintainer of the quicklaunch plasmoid I'm going to comment on this. The patch looks fine to me, although I would probably show in the MessageBox which item gets removed. That way the user can easily recognize *before* removing the item if he clicked the wrong item or not. Lukas
First, this is the wrong way to fix it. Why should this confirmation only go for a specific widget? This introduces inconsistence in the UI that leads to more data loss (the next time a user deletes a widget, she'll expect there to be a confirmation, and there won't). Adding a modal dialog is a no-go as well, it blocks the UI and causes general nastiness. The correct solution against data loss bugs is not to add confirmation dialogs, but to make the action less destructive, for example by adding a way to undo the delete.