Added initial errorhandling

Review Request #102680 - Created Sept. 22, 2011 and submitted

Information
Thomas Balling Sørensen
polkit-kde-kcmodules-1
master
Reviewers
polkit-kde-kcmodules-1
dafre
Hi Dario (and others)

I have added some initial errorhandling in the helper and KCM client.
Do you have a good idea how to handle errors while saving several explicit or implicit settings? Right now I have commented the errorhandling out when we are in a foreach loop.

Should we:
1. stop at the setting currently handled and just return with a DBUS error?
2. continue and try save the rest and then maybe pick up all the error messages and collect them into one big error message?

The first approach would leave all the rest of the settings being unsaved. The second approach would save all the settings, leaving only the errornous settings unsaved, but the errorhandling will be far more complex.
What do you think?
I have tested it very roughly and it seems to work fine.
Dario Freddi
Dario Freddi
Thomas Balling Sørensen
Dario Freddi
Thomas Balling Sørensen
Review request changed

Status: Closed (submitted)

Loading...