Show removable media in Dolphin's "Copy To" and "Move To" context menus

Review Request #102657 - Created Sept. 18, 2011 and updated

Information
Rajeesh K V
kde-baseapps
master
251151
Reviewers
dolphin, kde-baseapps
dfaure
The most common usage for "{Copy,Move} To" dolphin context menus is that a user wants to copy/move a selected file to plugged in USB drive. Show the mounted removable media also along with "Root Folder" and recently used entries.

It would be nice to have "Places" sidebar instead of the current implementation, which includes Root Folder, Home Folder, Desktop Folder, other drives including removable media like USB drives etc. See bugs 140475, 251151 et al. This should also help in scenario where plugged in removable media is not automatically mounted (which is the default setup at least in Fedora). I couldn't find a way to easily extend that functionality, though.
Tested in KDE SC 4.7.0 in Fedora and also by another ArchLinux user.

Issues

  • 5
  • 0
  • 0
  • 5
Description From Last Updated
Create it on the stack, if its lifetime is limited to the current block. David Faure David Faure
Those would have to go. If we show the Places, which have Root and Home by default, there is no ... Kai Uwe Broulik Kai Uwe Broulik
Why are the Places (root is understandable but not the Places) ifdef'd out on Windows? Kai Uwe Broulik Kai Uwe Broulik
imho the Bluetooth place should not be shown since we have that "Send via bluetooth" icon and I doubt that ... Kai Uwe Broulik Kai Uwe Broulik
Can you ensure that devices are not shown duplicated (ie. from the Places and then from the Harddrive letters) Kai Uwe Broulik Kai Uwe Broulik
Christoph Feck
Rajeesh K V
Christoph Feck
Frank Reininghaus
Rajeesh K V
Review request changed

People:

+dfaure
David Faure
I like the idea, but I don't understand the screenshot. Is that "before" or "after"? Why does it say "without devices"? It shows Home and Root twice, could that be fixed?
  1. I used kFilePlacesModel as suggested by Christoph Feck, but it doesn't list devices (fixed/removable); and not yet got around fixing that. Home and Root are already listed by KonqCopyToMainMenu::slotAboutToShow() and using KFilePlacesModel lists them again - can be fixed easily.
lib/konq/konq_copytomenu.cpp (Diff revision 2)
 
 
Create it on the stack, if its lifetime is limited to the current block.
Kai Uwe Broulik

   
lib/konq/konq_copytomenu.cpp (Diff revision 2)
 
 
 
 
 
 
 
 
 
 
 
 
 
 
Those would have to go. If we show the Places, which have Root and Home by default, there is no need for these anymore.
lib/konq/konq_copytomenu.cpp (Diff revision 2)
 
 
Why are the Places (root is understandable but not the Places) ifdef'd out on Windows?
lib/konq/konq_copytomenu.cpp (Diff revision 2)
 
 
imho the Bluetooth place should not be shown since we have that "Send via bluetooth" icon and I doubt that the Bluetooth entry will work in that menu
lib/konq/konq_copytomenu.cpp (Diff revision 2)
 
 
 
 
 
 
 
Can you ensure that devices are not shown duplicated (ie. from the Places and then from the Harddrive letters)
Loading...