Make Dolphin honour the KGlobalSettings::singleClick option.

Review Request #102447 - Created Aug. 26, 2011 and submitted

Information
Tirtha Chatterjee
kde-baseapps
master
Reviewers
kde-baseapps
ppenz
Honours the KGlobalSettings::singleClick() setting (set from Mouse KCM, whether files should be opened on single or double clicks), and functions accordingly.
Yes tested and works.
Peter Penz
Tirtha Chatterjee
Review request changed

Change Summary:

Made the suggested changes, also now respecting KGlobalSettings::changeCursorOverIcon()

Diff:

Revision 2 (+20 -2)

Show changes

Peter Penz
Thanks for the update, but could you please revert the changes with KGlobalSettings::changeCursorOverIcon()? I consider this option an unnecessary "micro-option" and plan to implement the same behavior as in Dolphin 1.7.
  1. Yeah sure. But TBH, it does feel a bit odd if a pointing hand cursor does not appear, and the folder opens on a single click. Reverting it, and committing for now.
  2. Thanks for pushing this!
    
    > But TBH, it does feel a bit odd if a pointing hand cursor does not appear, and the folder opens on a single click
    
    We'll introduce the pointing hand cursor later, but:
    - not as an option
    - and first the selection markers need to be reintroduced again, as this will make the code for the "pointing hand" a little bit more complicated
Commit Hook
This review has been submitted with commit b0db096e4a3efc58da1c341b9259eb890e90d451 by Tirtha Chatterjee to branch master.
Loading...