properly honor resource when applying filters to new emails

Review Request #102446 - Created Aug. 26, 2011 and discarded

Information
Milian Wolff
kdepim
master
Reviewers
kdepim
This is most probably just a dirty "get it working" patch, but I want to post it here for review. First the problem it solves:

When starting kmail, it will apply all filters to all new emails without honoring the "apply this filter to incoming messages: from checked accounts only" setting.

The easiest way to notice is by having a "spamc" or spamassassin (or similar) filter that takes a long time and have that apply to only a very specific account. Then, when a different account gets new email you should see a load spike / spamc processes even though there should be none.

Imo the whole design of FilterManager::process's function signature is pretty bad. Shouldn't/couldn't the optional stuff be removed and item.parentCollection().resource() be used instead?
ran kmail2 for ~1 day. it finally worked like it should
Laurent Montel
Ingo Klöcker
Milian Wolff
Ingo Klöcker
Milian Wolff
Review request changed

Status: Discarded

Change Summary:

seems to be obsoleted by Tobias work on the filter agent.
Loading...