highlight host in urlbar

Review Request #102402 - Created Aug. 21, 2011 and updated

Information
Johannes Tröscher
rekonq
master
Reviewers
rekonq
highlight host in urlbar like in firefox.
this patch isn't finished yet.
this code also evaluates the actual textrect including all margins, so the "empty-progress==0" message will be drawn in the "real" center.
compiles and works.

Screenshots


Johannes Tröscher
Tirtha Chatterjee
Johannes Tröscher
Johannes Tröscher
Andrea Diamantini
Andrea Diamantini
Johannes Tröscher
Johannes Tröscher
Johannes Tröscher
Johannes Tröscher
Johannes Tröscher
Johannes Tröscher
Johannes Tröscher
Review request changed

Change Summary:

improved drawing code

Diff:

Revision 9 (+79 -29)

Show changes

Andrea Diamantini
It is really improved from the first version tried :)
Anyway, I think its behavior has to modified. In fact Firefox/Chrom* don't have a loading animation on their urlbar, so I really think this feature should work just on loadFinished (and probably also moved there). I mean that during page load, everything should be normal and "coloring" activated just on loadFinished.
  1. should be just an easy check on progr. i'll post an updated version
  2. Why would it be so important that the coloring only comes into place on loadFinished? Don't see where it would conflict, and finally it's a security related feature, so we want the user to be informed as soon as possible of the actual domain they landed on.
    
    Possibly the gray should be quite a bit darker to improve readability, not only but especially in private mode.
    Also, now that the urlbar doesn't turn greenish anymore, the "https:" protocol should turn green the way it does in Chromium.
    But then the coloring IMHO should be fine enough for now.
    
    @Johannes:
    Are you still ready to post an updated version, or should somebody continue working on it?
  3. This patch is not working as expected and I found no way to fix in a proper way. At least with my knowledge in a Qt4/QPainter world. This review request is still open because... Johannes is dead. One year ago. In a tragic accident.
    I'll try to implement this feature in a different way as soon as we'll move to Qt5.
    Regards. 
Loading...