rate control in ftp kio slave with review comments fixes

Review Request #102307 - Created Aug. 11, 2011 and updated

Information
Tushar Mehta
kdelibs
Reviewers
kdelibs
adawit, dfaure, lappelhans, thiago, zander
This patch is trying to clear the comments of the previous patch.(https://git.reviewboard.kde.org/r/102307/)

  

Issues

  • 4
  • 0
  • 0
  • 4
Description From Last Updated
Actually, to avoid detaching, data(QByteArray()) might be faster. But I'm nitpicking, feel free to ignore that :) David Faure David Faure
the comment is a bit outdated and unnecessary now. Yes the buffer is empty, there's a clear right above :-) David Faure David Faure
Can you use the kdelibs coding style for new code? That would mean c-basic-offset = 4 (and reindenting the file, ... David Faure David Faure
BTW I fixed that for Qt 5 (usleep is now public) so you can add a "QT5 TODO: remove" comment. David Faure David Faure
Christoph Feck
Oh, you opened a new review instead of updating it :) Please close/discard the old review request.
  1. I closed the old review request. :)
David Faure
Looks good. Just a few small comments...
kioslave/ftp/ftp.cpp (Diff revision 1)
 
 
Actually, to avoid detaching, data(QByteArray()) might be faster. But I'm nitpicking, feel free to ignore that :)
kioslave/ftp/ftp.cpp (Diff revision 1)
 
 
the comment is a bit outdated and unnecessary now. Yes the buffer is empty, there's a clear right above :-)
kioslave/ftp/ratecontroller.h (Diff revision 1)
 
 
Can you use the kdelibs coding style for new code? That would mean c-basic-offset = 4 (and reindenting the file, not just changing the mode line) :-)
kioslave/ftp/ratecontroller.cpp (Diff revision 1)
 
 
BTW I fixed that for Qt 5 (usleep is now public) so you can add a "QT5 TODO: remove" comment.
David Faure
Hi. Do you plan on updating the patch once more? Sorry for the many iterations -- this what gives quality code in the end though.
  1. Hey!
    Thanks for the heads up here, I would like to see this in kdelibs/frameworks as well! If there is noone else willing to fix the remaining issues, I will do it! :)
Loading...