Dragging a fullscreen window to another screen and then disabling fullscreen keeps the window at the new screen.

Review Request #102103 - Created July 27, 2011 and submitted

Information
Matthias Fuchs
kde-workspace
4.7
261704
Reviewers
kwin
graesslin
I think the screen number solution is not ideal, though it works.
What do you think?
Tested with two screens with the 4.7 branch and the master branch.
Thomas Lübking
Matthias Fuchs
Review request changed

Change Summary:

Uses checkWorkspacePosition and also takes xineramaFullscreenEnabled into consideration.

@Thomas the patch you linked is not in branch 4.7 but just master, so I tested the patch you linked only with master. Yet I want to backport this review here also to 4.7, but as far as I can tell it works nice with both master and 4.7.

Diff:

Revision 2 (+22 -3)

Show changes

Martin Flöser
Just use an int :-)
kwin/client.h (Diff revision 2)
 
 
I don't like this variable name and think we should break with the existing naming scheme: m_fullScreenFoo :-)
Commit Hook
This review has been submitted with commit d35ec6d18377fd872207b88dd39f560a483bcc14 by Matthias Fuchs to branch KDE/4.7.
Commit Hook
This review has been submitted with commit 63604784e610fab38a10eb60a5210d71ded8f12d by Matthias Fuchs to branch master.
Loading...