Prevent last.fm credential popup on Amarok start if none are set

Review Request #102079 - Created July 24, 2011 and submitted

Information
Sam Lade
amarok
Reviewers
amarok
As of commit 202c49ebf8b5521b0394b4b7c5e816bf4057c8de, if the Last.FM plugin is enabled, but no username and password are set, a request for the username and password is popped up on Amarok start.
This is because this commit calls polish() on each service as it is created. If the service hasn't set m_inited = true when this happens (which is the case when no last.fm username and password are set), a dialogue pops up asking for them.

This simply removes that call. It was never run in older versions of Amarok, since apparently polish() was never called.

There may be better ways of doing it, but if so I can't work them out. Everything seems to work properly this way.
Amarok started with and without last.fm credentials set. Everything seems to behave as expected. No badgering popups are shown.
Bart Cerneels
FYI: http://quickgit.kde.org/?p=amarok.git&a=commitdiff&h=202c49ebf8b5521b0394b4b7c5e816bf4057c8de
Bart Cerneels

   
src/services/lastfm/LastFmService.cpp (Diff revision 1)
 
 
This should never have been here in the first place. If the service is enabled but unconfigured at most a inline error message should be shown. Popup dialogs are annoying.
Commit Hook
This review has been submitted with commit 22b369ddfe14cb7109eb39d08c6f9786dea9b578 by Sam Lade to branch master.
Loading...