fix #277269 Dolphin(Part) Detail/Tree view, highlighted selection paint glitch

Review Request #101924 - Created July 11, 2011 and submitted

Information
Marcel Partap
kde-baseapps
Reviewers
kde-baseapps
dfaure, ppenz
What was strange that background highlighting and actual item selection were drawn independently from each other and the bogus highlighting to the left of the item was not cleared... Now this one was a __REAL__ bitch to get dealt with, took me hours and hours bashing my head against the shell ^^
ok now again the viewOptions is not only not the place to turn off background highlighting, but there it was even tried to ENABLE it :O
turned out this so called QStyle::SH_ItemView_ShowDecorationSelected	documented as "When an item in an item view is selected, also highlight the branch or other decoration." is hard-coded on by DEFAULT in QCommonStyle and all inheriting from there so it requires a QProxyStyle to override the setting. While we have the opportunity, also set SH_ItemView_ArrowKeysNavigateIntoChildren for added joice of keyboard navigation (although strange effect comes up when being on a leaf and pressing Cursor::Right again - but with or without this setting, something with the selection handler...)
...now someone owes me CAKE for this one :D
head-bashing
Peter Penz
Peter Penz
Marcel Partap
Review request changed

Change Summary:

This should have the proxy style destroyed with the treeview instead of leaking it.
> would only make sense to push it to the 4.7 branch.
What exactly do you mean by 'only'? Isn't 4.7 the branch just about to be released and which will be in all distros until sometime next year?
Or am i the only one who has this? couldn't find a bug report about it.
Anyways. Also have got my git setup now in case you can't be bothered typing a commit message :)

Diff:

Revision 2 (+24 -1)

Show changes

Peter Penz
Thanks for the update!

>> would only make sense to push it to the 4.7 branch.
> What exactly do you mean by 'only'? Isn't 4.7 the branch just
> about to be released and which will be in all distros until sometime next year?

I meant that this change should only be pushed to the KDE/4.7 and not to master as this class will be removed from master around the beginning of August (Dolphin 2.0...)
  1. Hi Peter,
    sorry was busy with uni stuff.. could you please take care of applying this to the correct branch? i don't want to mess up the git.. looking forward to see the new branch evolving... (from its currently somewhat disfunctional state.. really need that file selection 'feature' *g)
  2. I just wanted to merge the patch, but after trying it myself now I've been surprised that you obviously did not test the patch for regressions in combination with Oxygen as I've asked you above. Sadly I don't have the time currently to investigate into this further, as I'm busy with getting Dolphin 2.0 in shape...
Loading...