make folderview icons translucent if composite is enabled
Review Request #101463 - Created May 28, 2011 and updated
|Mathias Stephan Panzenböck|
This patch makes dragged folderview icons translucent if composite is enabled. It is a kinda hack that uses an event filter to find Qt's D'n'D window, clears any mask on it and sets the Qt::WA_TranslucentBackground attribute. I use it day to day and it works fine. The proper place to fix this would be in Qt, but they wrongfully marked the bug report as invalid, because they think X11 does not support translucent windows: http://bugreports.qt.nokia.com/browse/QTBUG-8519
Not sure wheher it's really worth it (though using ARGB over XShape might actually bring better performance) but I assume the style (oxygen) can deal this more efficiently (via polishment) and also globally (not only for the folderview plasmoid but _all_ Qt icon drags) Gonna try and send Hugo a "patch" if it works.
Review request changed
I know that this won't get merged (I agree, it is a total hack), but maybe someone is still interested and want's to use this patch. So I rebased it on current KDE 4.8 GIT (=4.8.2).
Revision 2 (+22 -4)
For the record, I have implemented a 'modified' version of Thomas patch in oxygen (without the "clearMask()" call that could possibly break things elsewhere), and it just works (without this current patch implemented). See: http://wstaw.org/m/2012/05/03/dnd0.png This is pushed to master. I do not think it requires backporting to KDE 4.8 (As a side note, I have also implemented alpha channel for Window tabbing dnd icons, in oxygen-decoration, to test the above. See: http://wstaw.org/m/2012/05/03/dnd1.png) I believe this review request can therefore be discarder.