Do not modify .fonts.conf when loading it. Now nothing is written before the user clicks apply or ok. Fixes Bug 105797.
Review Request #101359 - Created May 13, 2011 and updated
I simply removed all code in loading routines that wrote something to the config. On a side-note, I'd love to rip out the whole fontconfig configuration completely... I think that the whole modifying-.fonts.conf-approach is too fickle because the system/distribution can set up elaborate hinting/antialiasing configurations and the changes made to .fonts.conf just bulldoze over them. Most people will probably never (really want to) touch those settings anyway (Windows and Mac OS X users at least don't seem to, and they don't appear to be unhappy about it)... Would there even be any good alternative approaches?
- Delete .fonts.conf and see if invoking "kcmshell4 fonts" creates it again without user intervention - Delete various match-settings set by the kcm (e.g. hintstyle and rgba) and see if it recreates them while leaving match-settings not deleted untouched - Switch anti-aliasing settings between system, disbled and enabled and apply each time, change some aa-settings while enabled and check if they stay there after switching
This patch does not apply to current master. Can you recreate it? patching file fonts.cpp Hunk #1 FAILED at 328. 1 out of 1 hunk FAILED -- saving rejects to file fonts.cpp.rej patching file kxftconfig.cpp
> Would there even be any good alternative approaches? Yes, - properly read the fontconfig (including global settings) - only write settings actually touched by the user - have a checkbox to disable custom font configuration (i.e if not enabled, store the settings in a private config for later use, but wipe the ~/.fonts.conf