Enable kdialog to set an icon for passivepopup as well

Review Request #101282 - Created May 3, 2011 and submitted

Information
Kai Uwe Broulik
kde-baseapps
Reviewers
kde-baseapps
Since I use kdialog a lot, I wanted it to be able to set an icon for passive Plasma notifications as well.
I saw that the icon was hardcoded to dialog-information and tried to enable it to parse the --icon command line argument and pass it to the dbus call that triggers the notification.
I could not test the patch however, since I do not (yet) have a full development environment or its dependencies, and I do not even know if this is the right approach, but I hope you can have a look at it.

  
Kai Uwe Broulik
Christoph Feck
Shaun Reich
Kai Uwe Broulik
Kai Uwe Broulik
Christoph Feck
Kai Uwe Broulik
David Palacio
Kai Uwe Broulik
Christoph Feck
Kai Uwe Broulik
Review request changed

Change Summary:

Changed text parameter to const ref and removed passiveiconkil (=Passive icon K Icon Loader :P) variable.
I don’t have commit rights.

Diff:

Revision 7 (+46 -19)

Show changes

Commit Hook
This review has been submitted with commit 8953d76773a39a756513280a04409f8984840268 by Christoph Feck.
Loading...