Fix 260352: Show hidden tracks warning when tracks are removed after filtering

Review Request #100928 - Created March 23, 2011 and discarded

Information
Nikhil Marathe
amarok
master
260352
Reviewers
amarok
Fix 260352 where removing tracks from the playlist after applying a filter, does not show the "Warning: tracks have been hidden in the playlist" label.

This fixes it by re-applying the filter on the PrettyListView so that it emits the found/notFound signals. Since the filter itself hasn't changed, proxy updates don't happen, so it shouldn't be a performance hit.

Change is minor but submitted for review since it is an unfamiliar piece of code, and also for educational purposes
Yes, it works fine. It is shown only when all filtered tracks are deleted as expected.
Ralf Engels
Myriam Schweingruber
Nikhil Marathe
Review request changed

Status: Discarded

Change Summary:

Commit 3ea0a0cc4320a9bd54e7ce44425fd6a0022ca20a solves the problem as proposed below.
Loading...