Add a hidden option to disable the tab highlight effect

Review Request #100863 - Created March 15, 2011 and discarded

Information
Felix Rohrbach
rekonq
267234
Reviewers
rekonq
This is a workaround for bug 267234. Disabling the effect seems to prevent the bug from happening. As it's no fun to use and test rekonq-git while this bug exists, I'd like to see this workaround in rekonq until the bug is fixed.
Tried to reproduce the bug for half an hour, it didn't occur anymore.
Andrea Diamantini

   
src/tabhighlighteffect.cpp (Diff revision 1)
 
 
I cannot understand how can, disabling the whole tabbar, help in any way...
  1. I don't understand what you mean. I just disable the effect, not the tabbar.
  2. If I can read your code well you wrote: 
    if (! Rekonfig::useTabEffects() )
        setEnabled(false)
    
    NOT
    
    m_graphicsEffects -> setEnabled(false)
    
    You are launching "this->setEnabled(false)", the tabbar, hence the effect, the mouse, the keyboard... everything against the tabbar.
    
  3. As I wrote the code in the effect class, "this" points to the effect, not to the tab bar.
  4. As you wrote in the TabHighLightsEffect class, it seems I need a new pair of glasses... :)
  5. :) May I push it?
Pierre Rossi
Looks good to me.
(Note to self: Even if this one is meant to be temporary, it sounds like yet another good candidate for about:config... Which makes me think I should really get back to that.)
Andrea Diamantini
Sorry again for my stupid error...
Anyway I think we don't need here an "hidden" option, because we should let people disable this quite easily if they yet have problems with. So, I vote for a "shown option", with a checkbox in the tabs dialog and its settings updated in the updateConfiguration slot.
Andrea Diamantini
Sorry again for my stupid error...
Anyway I think we don't need here an "hidden" option, because we should let people disable this quite easily if they yet have problems with. So, I vote for a "shown option", with a checkbox in the tabs dialog and its settings updated in the updateConfiguration slot.
Loading...