BSSID not recoginized

Review Request #100674 - Created Feb. 17, 2011 and submitted

Information
Rex Dieter
networkmanagement
Reviewers
networkmanagement
BSSID is provided in a bad format to NM daemon, which causes connection failures.  Also, MAC address is not sent correctly
when you use "Restrict to Interface" combo. For WiFi that causes connection failure, for wired the setting is just
ignored.

See also, https://bugs.kde.org/show_bug.cgi?id=238046
Patch has been tested in the wild in fedora for awhile, a gentoo user in aforementioned bug reports success as well.
Sebastian Kügler
Patch looks good, apart from some minor coding style issues. Please fix those and commit.

(I haven't tested it, but trust those that have =)
  1. done, thanks!
    
    http://quickgit.kde.org/?p=networkmanagement.git&a=commit&h=e6a2b8626c998f5ebc2e6bf0bf927462201e039d
backends/NetworkManager/settingdbus.h (Diff revision 1)
 
 
(both lines) run & and argument together
backends/NetworkManager/settingdbus.cpp (Diff revision 1)
 
 
pull together & and nexMc 
backends/NetworkManager/settingdbus.cpp (Diff revision 1)
 
 
separate lines, parentheses
backends/NetworkManager/settingdbus.cpp (Diff revision 1)
 
 
no whitespace between & and binMac
backends/NetworkManager/settingdbus.cpp (Diff revision 1)
 
 
Separate lines and parentheses, please
Loading...