Review Request #100575 - Created Feb. 5, 2011 and discarded
|adjam, pierrerossi, poulain|
firefox4-like urlpreview. replaces the preview popup at the lower left corner. i don't have a kde-git account, so please merge it if you like it.
compiles and works.
It works fine! and it's a really good patch, thanks for that. All I can say is there is an empty line with spaces (line number 199 in src/mainwindow.h) and I guess the 223rd line in urlbar.cpp should be if (text().isEmpty() && progr == 0 && !m_urlPreview->isVisible()) Sorry for a short review I don't really have enough knowledge for those code to review them.
I personally prefer the actual way to show urls. Our urlbar tends to be really particular and I see problems for people having lots of buttons in the toolbar and having a smaller sized urlbar.