A bit of cleanup in Application.

Review Request #100316 - Created Jan. 7, 2011 and submitted

Information
Pierre Rossi
rekonq
master
N/A
Reviewers
rekonq
poulain
I believe we don't need static members in QWeakPointers for all the *Managers, static getter functions would do the job.
"compiles and runs" ™
Benjamin Poulain
Pierre Rossi
Benjamin Poulain
Pierre Rossi
Andrea Diamantini
Andrea Diamantini
Pierre Rossi
Review request changed

Change Summary:

With the extra bits cleaned-up too, and no need for QScopedPointer.

Diff:

Revision 4 (+206 -230)

Show changes

Andrea Diamantini
:)
Andrea Diamantini

   
src/application.h (Diff revision 4)
 
 
I was thinking again here... why don't we get rid of these, too?
  1. Sure, we could make them bold pointers as far as I'm concerned.
Andrea Diamantini

   
src/application.cpp (Diff revision 4)
 
 
Aren't we missing the parent object here?
  1. yeah, I realized only after posting the diff that I hadn't re-added the file after adding instance() as a parent for this one. But I amended so it's there now ;)
Andrea Diamantini
(fast) Submitted to let people update their branches and don't get this (big) patch old.. ;)
Loading...