GCI Taks: Added support for pinning tabs

Review Request #100305 - Created Jan. 5, 2011 and discarded

Information
Furkan Üzümcü
rekonq
Reviewers
rekonq
Added support for pinning tabs like Firefox 4 and Google Chrome.
The default preview size was discussed on IRC.
* Tested and works.
Andrea Diamantini
Furkan Üzümcü
Jon Ander Peñalba
Furkan Üzümcü
Pierre Rossi

   
src/application.cpp (Diff revision 6)
 
 
style fixes could go in a different commit. Could you please split it?
src/application.cpp (Diff revision 6)
 
 
style fix (see above)
src/application.cpp (Diff revision 6)
 
 
style fix (see above)
src/application.cpp (Diff revision 6)
 
 
style fix (see above)
src/application.cpp (Diff revision 6)
 
 
maybe a more explicit variable name would help making the code more readable.
src/application.cpp (Diff revision 6)
 
 
style fix (see above)
src/application.cpp (Diff revision 6)
 
 
style fix (see above)
src/application.cpp (Diff revision 6)
 
 
style fix (see above)
src/application.cpp (Diff revision 6)
 
 
style fix (see above)
src/mainview.h (Diff revision 6)
 
 
why move it ?
src/tabbar.cpp (Diff revision 6)
 
 
I'm personally not a big fan of hijacking the tabData thingy for this purpose. Couldn't you keep a private QBitArray member and an accessor isTabPinned(int index) ?
src/tabbar.cpp (Diff revision 6)
 
 
the whole concept of using -1 as a default value for the (valid) current index feels a bit weird to me.
src/tabbar.cpp (Diff revision 6)
 
 
I'm not sure this case is even worth considering.
src/tabbar.cpp (Diff revision 6)
 
 
This could go very wrong. If for any reason indexOf returns -1 (for instance you're not looking at the same email in your pinned GMail), then I fear the whole thing may crash !

A check would be slightly better, but overall I feel the persistance could be handled differently.
src/tabbar.cpp (Diff revision 6)
 
 
actually, maybe this should respect the aspect ratio of the tab, just like other previews do. (i.e don't hardcode the height)
src/tabbar.cpp (Diff revision 6)
 
 
same remark for tabData()
Andrea Diamantini
uhm... I have a lot of doubts here. 
First, this patch changes rekonq behavior and this HAS to be fixed. In fact, leaving on a pinned tab, it is reloaded on startup. And this is not good. At least you can remember settings and reload them when the "restore last opened tabs" is set.
Second, I'm not sure changing tabbar dimension is enough to have a "pinned" tab. You should probably also set it to have just the icon.

ok, let's go with these, for now. Meeting time now.. :) 
  1. I guess this feature is for the next release. :(
    I cannot do what you say now. But I'll work on it and make it as close as to perfect.
Loading...