GCI Task: Added support for entering link directly into the Favorites section in the New Tab Page

Review Request #100286 - Created Jan. 2, 2011 and discarded

Information
Furkan Üzümcü
rekonq
Reviewers
rekonq
Added support for entering link directly into the Favorites section in the New Tab .
Preview selector bar shows up as you click on Add Favorites button.
* Tested and works!

Screenshots

Benjamin Poulain
Andrea Diamantini
Andrea Diamantini
Furkan Üzümcü
Furkan Üzümcü
Furkan Üzümcü
Rohan Garg
Furkan Üzümcü
Furkan Üzümcü
Furkan Üzümcü
Furkan Üzümcü
Furkan Üzümcü
Lionel Chauvin
I think you should split this patch in 3 patches. One per feature (1 for the bookmarkwidget, 2 for the previewselectorbar).
  1. I reverted the Bookmark Widget patch. and I don't think that is necessary. The patch is not too big.
  2. I think it is necessary because we are all agree about the feature "Preview selector bar shows up as you click on Add Favorites button.". The feature "Added support for entering link directly into the Favorites section in the New Tab . must still be discussed.
  3. But it's going to have the same patch in a different review request. If you agree that, I'm fine with it.
Rohan Garg
Could you modify this patch to suit HIG and do it the way that was discussed in #kde-usability?
  1. I can't for 2 reasons.
    1- I don't know what is discussed
    2- I'm not on Arch Linux.
    
    So please, can somebody do it for me? I want this feature for the next release!
  2. I dont see what Arch Linux has to do with this
  3. Well I'm using Windows Se7en now. I have neither KDE nor Linux.
  4. I can ensure you all the things you need (qt, kdelibs, cmake, git, gcc and so on) are available also on Windows 7...
  5. Please asnwer my question above.
Loading...