GCI Task: Prevent Rekonq from showing multi scroll button when middle click on scrollbars

Review Request #100276 - Created Dec. 31, 2010 and submitted

Information
Furkan Üzümcü
rekonq
Reviewers
rekonq
The "multiscroll" doesn't get toggled when hovering over the scrollbar.
(Rekonq Wish >> https://bugs.kde.org/show_bug.cgi?id=234888)
* Tested and works!
Furkan Üzümcü
Rohan Garg
Furkan Üzümcü
Review request changed

Summary:

-GCI Task: Prevent Rekonq from showing multi scroll button when click on scrollbars
+GCI Task: Prevent Rekonq from showing multi scroll button when middle click on scrollbars
Benjamin Poulain

   
src/webview.cpp (Diff revision 2)
 
 
Coding style:
Space missing between the if and the parenthesis.
The opening bracket should be on the same line as the if().
The patch's logic looks correct. Fix the coding style and put a better commit message and it is all good to me.
Pierre Rossi
I'm not sure that it's any better than what is currently shown. How about showing the appropriate cursors in those cases, i.e sb_h_double_arrow and sb_v_double_arrow ?
  1. on second thoughts, I think this shouldn't be handled by us, rather by QtWebKit... will need checking elsewhere.
Benjamin Poulain

   
src/webview.cpp (Diff revision 2)
 
 
 
 
 
Actually, no reason not to use a single if() here with all the conditions.
Pierre Rossi
Forget all the stuff I said, I see how this behavior would be more consistent with other KDE and Qt apps.

Just fix the points mentioned by Benjamin and it's all good. :)
Loading...