Please turn it on in your browser preferences.
for specific sites, we recommend the
Review Request #100236 -
Created Dec. 23, 2010 and submitted
Jan. 9, 2011, 10:46 a.m.
update the completion list when the user switch search engine
It seems working quite well in my first test. There are strange code changes that need discussion.
I don't understand the API change here. Why did you remove the string check here?
Suggestions was not displayed when you switch using a webshortcut. For example: "wp:a" != "a"
The goal of this code was to be sure that suggestions correspond to the typed text. I will reintroduce it in an other way if it is really needed.
Please, use Q_FOREACH instead
Is this really necessary? Comments, please.
You are right, the updateList signal seems to be emited twice. I will test to confirm that.
Not sure I understood what happened with the extractQuery function.. :)
the goal is to underline "a" in the text instead of "wp:a"
No, it is not that.
The extractQuery is not needed because "a" is passed to the opensearchManager instead of "wp:a". (webshortcuts was not working in the previous code)
Revision 2 (+68 -74)
Lionel, I admit I cannot properly review your code to understand the "general" changes you did, but just commenting line per line..
I trust your code and going to merge it.