Highlight updated tabs

Review Request #100224 - Created Dec. 20, 2010 and discarded

Information
Felix Rohrbach
rekonq
master
Reviewers
rekonq
This patch highlights inactive tabs if their title has changed, so people get aware of changes in the tabs (for instance a new message in a chat window).

Patch by fritz_van_tom.

It's a nice patch, but maybe we should remove the blinking, as this is very distracting.

I don't have a kde git account, so please merge it if you like it.
compiles and works
Pierre Rossi
I'm mostly concerned about the way the animation is done. The rest seems nice to me ! :)
src/mainview.cpp (Diff revision 1)
 
 
Style: no need to add an extra blank line with whitespace...
src/tabbar.cpp (Diff revision 1)
 
 
I can't say I'm a big fan of the timer-based approach, especially with the animation framework that's been in Qt since 4.6, I think it'd be more elegant.
Felix Rohrbach
The author of the patch changed it and put it on reviewboard here: http://git.reviewboard.kde.org/r/100230/
Closing this one now.
Loading...