GCI Task: Open multiple selected text links in new tabs

Review Request #100215 - Created Dec. 17, 2010 and discarded

Information
Panagiotis Papadopoulos
rekonq
mainline
248863
Reviewers
rekonq
When you select an area of text on the page that contains more than one link,
it would be very useful if you were given a right-click option to open those
links in new tabs.  This is a very useful feature in firefox.  An option to
open them in a single new window would also be nice, although not important
since it is easy enough to detach the tab first.

Taken from the Wish on bko

Patch by Andrzej G?owi?ski 
works here
Panagiotis Papadopoulos
Review request changed

Description:

   

When you select an area of text on the page that contains more than one link,

    it would be very useful if you were given a right-click option to open those
    links in new tabs. This is a very useful feature in firefox. An option to
    open them in a single new window would also be nice, although not important
    since it is easy enough to detach the tab first.

   
   

Taken from the Wish on bko

  +
  +

Patch by Andrzej G?owi?ski

Felix Rohrbach
Is working fine here, but I have two little comments:
1. Why do you only implent this action for more than one link selected?
2. Do you really think open all links in new windows is useful? I think it would be more useful if you would change that action to open all the links in one new window.
  1. I cannot find this feature in firefox and I personally doubt this is "useful": just because they are near, it does not really mean they are (all) interesting and related.
Jon Ander Peñalba
I would like to have the option of opening all the links in the selected text in new tabs, but I don't like how this patch implements it.

This patch only takes into account the text (if it starts with http://, https:// or www. it's a link), it doesn't look for actual links, and if they are both present this is not at all intuitive.
I would like to see this working only with actual links or not implemented at all.
  1. I would tend to agree with this: I believe actual links are more important than text that seems to be a valid url, and links will most likely not have http:// in their text. The problem is that there is no nice API in QtWebKit to to that at the moment, and using the selection and ranges in Javascript requires Javascript to be enabled, which we can't guarantee.
    
    Andrea has a point in his comment from December 17th: do we really need this ? As a side note: since a Javascript approach would work, this could be done quite simply via a bookmarklet.
Andrea Diamantini
Closed following discussion.
Loading...