Small bookmark API clean-up

Review Request #100126 - Created Nov. 1, 2010 and submitted

Information
Jon Ander Peñalba
rekonq
Reviewers
rekonq
laissus
I've done some clean-up to the bookmark API.
There are still some things I want to improve, I hope to work on it soon, but I've been busier  than expected lately.

This diff is more than one commit, if you want to see each commit look at my personal clone: http://gitorious.org/~Jonan/rekonq/jonans-mainline/commits/bookmark

  
Andrea Diamantini

   
  1. I like the changes you did, in general. Please, take care of the things listed below and then it's ok for me.
src/bookmarks/bookmarkowner.h (Diff revision 1)
 
 
You should probably change here the parameter name to bkGroup or something like that.
  1. Good point :)
src/bookmarks/bookmarkowner.cpp (Diff revision 1)
 
 
uhm... letting this without a parent will probably leak mem using it.
The same applies in the other occasions you removed it.
  1. I removed the parent because there's a delete at the end of the function that will be called a lot sooner than the activeWindow's destructor.
Loading...