Optimize rekonq protocol handling

Review Request #100062 - Created Oct. 14, 2010 and submitted

Information
Rohan Garg
rekonq
Reviewers
rekonq
adjam
This patch makes rekonq handle all possible protocols that KDE can handle, huge protocol optimization imo
Works perfectly on Kubuntu 10.10, tested with magnet/apt/ftp/mailto links
Rohan Garg
Review request changed

Testing Done:

~  

Works perfectly on Kubuntu 10.10, tested with magnet/apt/ftp links

  ~

Works perfectly on Kubuntu 10.10, tested with magnet/apt/ftp/mailto links

Andrea Diamantini
Very good!  Please also backport it to the 0.6 branch. If you need help doing it, ask without problem. Great work.
Pierre Rossi
looks good otherwise :)
src/protocolhandler.cpp (Diff revision 1)
 
 
Simply use else ?
  1. Right :)
Benjamin Poulain

   
src/protocolhandler.cpp (Diff revision 1)
 
 
 
KDE's coding convention, the bracket should be on the same line as the if().
  1. rekonq doesn't use exactly the same convention as KDE.
    
    http://gitweb.kde.org/rekonq.git/blob/HEAD:/scripts/codingstyle.sh
src/protocolhandler.cpp (Diff revision 1)
 
 
Typo: "itself" should probably be in one word here :)
src/protocolhandler.cpp (Diff revision 1)
 
 
Coding convention as well.
src/protocolhandler.cpp (Diff revision 1)
 
 
KDE's coding convention: no space after the opening parenthesis.
Loading...