Use QT_USE_FAST_CONCATENATION and QT_USE_FAST_OPERATOR_PLUS for performance.

Review Request #100008 - Created Sept. 29, 2010 and submitted

Information
Mark Kretschmann
amarok
Reviewers
amarok
    Use QT_USE_FAST_CONCATENATION and QT_USE_FAST_OPERATOR_PLUS for performance.
    
    See http://doc.trolltech.com/4.6/qstring.html#more-efficient-string-construction.
    
    I had to clean up lots of incorrect string concatenations. Please check for
    correctness.

This still fails to compile because of one error in libLastFM. Who is up for fixing the lib? :)
Rick Chen
Alex Merry
Edward Toroshchin
Mark Kretschmann
Review request changed

Change Summary:

Fixed LibLastFM build errors with Edward's CMake trick ( remove_definitions() ).

Still doesn't build here though, I get this:

:: error: CMakeFiles/amarok_service_lastfm.dir/LastFmService.o: in function DW.ref._ZTIN6lastfm2ws10ParseErrorE:LastFmService.cpp(.data.DW.ref._ZTIN6lastfm2ws10ParseErrorE+0x0): error: undefined reference to 'typeinfo for lastfm::ws::ParseError'


Could anyone else test?

Diff:

Revision 3 (+43 -35)

Show changes

Rick Chen
I built this successfully.
Loading...